Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for CI phase 3 #4088

Merged
merged 15 commits into from
Sep 20, 2023
Merged

Updates for CI phase 3 #4088

merged 15 commits into from
Sep 20, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 18, 2023 •
edited
Loading

What are you changing in this pull request and why?

Update docs for the GA of CI phase 3:

  • Create release notes
  • Update the Troubleshooting section -- removed the old Temp PR schema limitations section and consolidated the generate_schema_name use case into Troubleshooting
  • Update the How it works section -- updated the wording in the last paragraph to account for new changes

Checklist

Adding new pages (delete if not applicable):

  • Provide a unique filename for the new page

@nghi-ly nghi-ly requested a review from a team as a code owner September 18, 2023 19:04
@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 4:27pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Sep 18, 2023
@nghi-ly nghi-ly requested a review from aaronraff September 18, 2023 19:39
aaronraff
aaronraff requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@aaronraff aaronraff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've only requested one very small change to ensure that we are communicating the correct prefix that's required for temporary schema dropping.

website/docs/docs/dbt-versions/release-notes/04-Sept-2023/ci-updates-phase3-rn.md Outdated Show resolved Hide resolved
aaronraff
aaronraff approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@aaronraff aaronraff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I found one more occurrence of the required schema prefix that should be updated. No need to re-request a review though, everything else looks great. Thanks for doing this!

website/docs/docs/dbt-versions/release-notes/04-Sept-2023/ci-updates-phase3-rn.md Outdated Show resolved Hide resolved
mirnawong1
mirnawong1 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome! left some non blocking suggestions to help users as they read through these helpful docs. approved for you to merge @nghi-ly

@nghi-ly nghi-ly merged commit bbef370 into current Sep 20, 2023
7 checks passed
@nghi-ly nghi-ly deleted the ly-docs-ci-phase-3 branch September 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@aaronraff aaronraff aaronraff approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghi-ly @aaronraff @mirnawong1